From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 63DC862F7C for ; Mon, 24 Jan 2022 09:59:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5A2E61F6A1 for ; Mon, 24 Jan 2022 09:59:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E790E1F693 for ; Mon, 24 Jan 2022 09:59:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BBBF446137 for ; Mon, 24 Jan 2022 09:59:57 +0100 (CET) Message-ID: <09a6c918-6229-625c-fde1-e1bf0f1c9177@proxmox.com> Date: Mon, 24 Jan 2022 09:59:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Matthias Heiserer , Proxmox Backup Server development discussion References: <20220120093325.1120218-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] close #3103: default lang X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 08:59:58 -0000 On 24.01.22 09:54, Matthias Heiserer wrote: > Are the style guidelines documented somewhere, e.g. in a rustfmt.toml file or the wiki? If so, I couldn't find them. for rust we currently use the plain rustfmt settings, but it's not yet enforced on build or the like and quite some files are not yet converted. For new code we'd like to have it already correctly styled though, so using rustfmt directly or through your editor and disregarding the changes from unrelated code in the module would be the simplest way to ensure that. Please do not sent format cleanups for the whole file, those are just big and icky to handle over the list, that's best done by a maintainer directly. - Thomas