From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9101B1FF13A for ; Wed, 22 Jul 2026 12:29:21 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4815C214BB; Wed, 22 Jul 2026 12:29:21 +0200 (CEST) Message-ID: <0978c8f9-4f4c-4888-9218-171bc8a78379@proxmox.com> Date: Wed, 22 Jul 2026 12:28:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} v2 00/13] add GarbageCollection maintenance mode To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260702145916.360488-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260702145916.360488-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784716099852 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.183 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LSD7VEADYRZHPECB3F72GZ4YFL4ZE2EK X-Message-ID-Hash: LSD7VEADYRZHPECB3F72GZ4YFL4ZE2EK X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/2/26 5:00 PM, Robert Obkircher wrote: > Add a maintenance mode that allows reclaiming storage space without > the risk of running out of space because of new backups. > > Changes since [v1]: > * fix proxmox-biome formatting in OptionView.js > * task tracking: split starttime change into separate commit > * mention set_maintenance_mode in commit and improve comment > * avoid decoding maintenance mode message when it is unused > * documentation > > [v1] https://lore.proxmox.com/pbs-devel/20260602130001.217482-1-r.obkircher@proxmox.com/ > Consider the whole series: Reviewed-by: Christian Ebner Tested-by: Christian Ebner Send one small followup to fixup outdated docstrings for maintenance types [0] to be considered when applying this series. One thing I'm still questioning is if we should rework the active operations a bit more, allowing for processes to only serialize and update the respective part of their PID when writing the json file and maybe encode the running version of the PBS process within that. This could then potentially be used to detect a min running version Of course this will require a breaking change at some point, since all older process version will overwrite the file with their currently known serialization format. [0] https://lore.proxmox.com/pbs-devel/20260722101720.141156-1-c.ebner@proxmox.com/T/