From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E60D1FF17C for ; Wed, 23 Jul 2025 15:46:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34EE213BBF; Wed, 23 Jul 2025 15:48:03 +0200 (CEST) Message-ID: <08d9116e-cf96-4869-b317-3412e0948ec8@proxmox.com> Date: Wed, 23 Jul 2025 15:48:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Christian Ebner References: <20250723091357.353331-1-c.ebner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250723091357.353331-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753278469858 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [client.rs] Subject: [pbs-devel] applied: [PATCH proxmox] s3 client: fix invalid request for empty delete_objects call X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 23.07.25 um 11:15 schrieb Christian Ebner: > The s3 client's object_delete method does not correctly handle cases > where an empty list of object keys is passed via the parameters, > resulting in an `invalid request` error. > > Handle this by early returning in case of an empty list, thereby also > skipping the unneeded api request altogether. > > This indirectly fixes the snapshot directory cleanup for > proxmox-backup-client benchmark or aborted backups, where no objects > have been persisted to the object store within the snapshot prefix > yet, therefore trying to delete the empty list. > > Reported-by: Dominik Csapak > Signed-off-by: Christian Ebner > --- > Note: as this indirectly fixes an issue in PBS, latter must be build > against a bumped version of the proxmox-s3-client. > > Further, I'm working on improving the error logging for such invalid > requests, as they currently do not log the error in the response body > (if any) in these cases. > > proxmox-s3-client/src/client.rs | 4 ++++ > proxmox-s3-client/src/response_reader.rs | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > applied, thanks! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel