From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DBB1F1FF141 for ; Mon, 13 Apr 2026 10:54:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C31CF1C990; Mon, 13 Apr 2026 10:55:46 +0200 (CEST) Message-ID: <08c4d94e-2182-4708-ad8a-dd1eca6ea881@proxmox.com> Date: Mon, 13 Apr 2026 10:55:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v2 11/27] api: config: check sync owner has access to en-/decryption keys To: Thomas Lamprecht References: <20260411085154.1961287-1-t.lamprecht@proxmox.com> <20260411085154.1961287-5-t.lamprecht@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260411085154.1961287-5-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776070439608 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sync.rs] Message-ID-Hash: IGE5M7IER6UXJTE3VO4VNUYLECM7P4QN X-Message-ID-Hash: IGE5M7IER6UXJTE3VO4VNUYLECM7P4QN X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/11/26 10:50 AM, Thomas Lamprecht wrote: > Am 10.04.26 um 18:54 schrieb Christian Ebner: >> diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs >> @@ -62,6 +62,16 @@ fn is_correct_owner(auth_id: &Authid, job: &SyncJobConfig) -> bool { >> >> +fn sync_user_can_access_optional_key(key_id: Option<&str>, owner: &Authid) -> Result<(), Error> { >> + if let Some(key_id) = key_id { >> + if crate::server::sync::check_privs_and_load_key_config(key_id, owner, false).is_err() { >> + bail!("no such key or cannot access key '{key_id}'"); >> + } >> + } >> + Ok(()) >> +} > > For push direction, the call passes fail_on_archived=false, meaning an archived > key is accepted as active_encryption_key at job creation/update time. The push > runtime (PushParameters::new) does pass fail_on_archived=true, so the job would > fail when actually executed, but the error only shows up then - not when the > admin edits the config. should the push path use fail_on_archived=true here > too? Yes, indeed. When setting the active encryption key it should always be checked if the key is not archived. Will expose this additional flag also to sync_user_can_access_optional_key(), so it can be checked respectively.