From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 27D6871AFD for ; Fri, 11 Jun 2021 15:21:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 1DA1212F38 for ; Fri, 11 Jun 2021 15:21:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id A580E12F2A for ; Fri, 11 Jun 2021 15:21:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 7F564406C1; Fri, 11 Jun 2021 15:21:25 +0200 (CEST) Message-ID: <0871b037-d1ec-98c1-3f64-26b1f67210f5@proxmox.com> Date: Fri, 11 Jun 2021 15:21:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Hannes Laimer References: <20210611075046.34449-1-h.laimer@proxmox.com> <20210611075046.34449-4-h.laimer@proxmox.com> From: Dominik Csapak In-Reply-To: <20210611075046.34449-4-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.929 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-manager.rs] Subject: Re: [pbs-devel] [PATCH v1 proxmox-backup 3/3] manager_bin: add --ignore-verified and --outdated-after parameters X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 13:21:56 -0000 comment inline: On 6/11/21 09:50, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/bin/proxmox-backup-manager.rs | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs > index c3806a31..e0baa20d 100644 > --- a/src/bin/proxmox-backup-manager.rs > +++ b/src/bin/proxmox-backup-manager.rs > @@ -269,6 +269,14 @@ async fn pull_datastore( > "store": { > schema: DATASTORE_SCHEMA, > }, > + "ignore-verified": { > + schema: IGNORE_VERIFIED_BACKUPS_SCHEMA, > + optional: true, > + }, > + "outdated-after": { > + schema: VERIFICATION_OUTDATED_AFTER_SCHEMA, > + optional: true, > + }, > "output-format": { > schema: OUTPUT_FORMAT, > optional: true, > @@ -286,7 +294,7 @@ async fn verify( > > let mut client = connect_to_localhost()?; > > - let args = json!({}); > + let args = json!(param); > caution, this still potentially contains the 'output-format' parameter which will not work with the api, so we have to remove it here (or use the 'extract_output_format' instead above) > let path = format!("api2/json/admin/datastore/{}/verify", store); > >