From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 180F2691C6
for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 13:41:44 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0B8B21CFDB
for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 13:41:44 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 6083E1CF93
for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 13:41:42 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 249D946015
for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 13:41:42 +0100 (CET)
Message-ID: <0814baf1-ab66-a67a-cee0-453072e844cb@proxmox.com>
Date: Wed, 10 Mar 2021 13:41:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101
Thunderbird/87.0
Content-Language: en-US
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20210310091047.16557-1-d.csapak@proxmox.com>
<20210310091047.16557-2-d.csapak@proxmox.com>
<2ddefdf1-b6e8-9c23-caef-aa7de1c58005@proxmox.com>
<491dc073-0b9f-8849-051e-156c6c38c05f@proxmox.com>
<91149079-342d-97dc-b557-2ea7f95e440f@proxmox.com>
<8b5efacb-163f-8e1a-4b37-bf640a8fd031@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <8b5efacb-163f-8e1a-4b37-bf640a8fd031@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.049 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [sencha.com, data.store]
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase
tapestore interval
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2021 12:41:44 -0000
On 10.03.21 13:32, Dominik Csapak wrote:
> On 3/10/21 12:47 PM, Thomas Lamprecht wrote:
>> On 10.03.21 12:38, Dominik Csapak wrote:
>>>
>>>
>>> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>>>> On 10.03.21 10:10, Dominik Csapak wrote:
>>>>> from 2 to 60 seconds. To retain the response time of the gui
>>>>> when adding/editing/removing, trigger a manual reload on these actions
>>>>>
>>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>>
>>>> Please add my Suggested-by or Reported-by tags for reference the next time,
>>>> thanks!
>>>>
>>>
>>> yes of course, sorry
>>
>> Thanks!
>>
>> btw. can you please freshen up my brain on the storeid config from UpdateStore?
>> As its not used there directly and it's base class Ext.data.Store only knows
>> about storeId [0] (note the casing difference), and using that one would actually
>> register the store to the Ext.data.StoreManager [1] and we could avoid the detour
>> over querying the nav tree but do a
>>
>> Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();
>>
>> instead. Not sure about any extra cost of that manager, but code wise it would
>> be quite less (and only called from places where we know that PBS.enableTapeUI
>> is true already).
>>
>> And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
>> over, or really misspelled then I'd maybe drop it or fix spelling, respectively.
>>
>> [0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
>> [1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html
>
> mhmm after taking a short look at it, we require 'storeid' in the UpdateStore, otherwise it fails with an exception. But i cannot find
> any actual use for that, so i assume it was meant to be storeId in the
> first place but we never noticed
yeah so same findings I had.
>
> i'll check if changing it to storeId has any negative side-effects
> (such as leftover stores after some panel gets destroyed) and would
> send patches to change all occurrences to storeId
>
> if it's too costly (or has other issues) i'd prepare patches to
> drop it from the UpdateStore altogether (since we do not
> seem to use it)
Thanks!