From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 77D741FF13E for ; Fri, 17 Apr 2026 14:26:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53BB543D; Fri, 17 Apr 2026 14:26:29 +0200 (CEST) Message-ID: <07eee76f-6065-48d5-babb-dcd40a2c3881@proxmox.com> Date: Fri, 17 Apr 2026 14:26:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] client: repository: add individual component parameters To: Thomas Lamprecht , pbs-devel@lists.proxmox.com References: <20260410154327.4133440-1-t.lamprecht@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260410154327.4133440-1-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428705474 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ARWXRFVB2OITCLEZYB5W5NFXPCYPVQS2 X-Message-ID-Hash: ARWXRFVB2OITCLEZYB5W5NFXPCYPVQS2 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/10/26 5:43 PM, Thomas Lamprecht wrote: > Follow-up to [v3], reworked based on Wolfgang's and Christian's review > feedback - thx! > > The compact repository URL format ([[auth-id@]server[:port]:]datastore) > can be cumbersome to work with when changing a single aspect of the > connection or when using API tokens. This series adds --server, --port, > --datastore, --auth-id, and --ns as separate CLI parameters alongside > the existing compound --repository URL. > > Changes since [v3]: > - Deduplicated mutual-exclusion check into check_mutual_exclusion() > - Used AllOfSchema for mount.rs raw ApiMethod definitions > - Commands where --ns is irrelevant (login, logout, version, status, GC, > benchmark, task) now use BackupRepositoryArgs only > - Moved optional_ns_param() to pbs-client tools as shared helper > - Fixed change_backup_owner not stripping atom fields before forwarding > - Small nits (anyhow::bail! -> bail!, private ENV_VAR_PBS_NAMESPACE) > > Changes since [v2]: > - Deduplicated param resolution cascade into shared helper > - Split into BackupRepositoryArgs and BackupTargetArgs (repo + ns) > > Changes since [v1]: > - Split single commit into five > - CLI atoms now merge with PBS_* env vars per-field (CLI wins) > - Fixed mutual-exclusion error swallowing and duplicate ns property > - PBS_NAMESPACE works uniformly across all three client binaries > > [v3]: https://lore.proxmox.com/pbs-devel/20260401225305.4069441-1-t.lamprecht@proxmox.com/ > [v2]: https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/ > [v1]: https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/ Reviewed-by: Christian Ebner Tested-by: Christian Ebner