From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E18219EB3F for ; Tue, 28 Nov 2023 13:49:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB4AE16D94 for ; Tue, 28 Nov 2023 13:48:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 13:48:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C370B40EF5 for ; Tue, 28 Nov 2023 13:48:53 +0100 (CET) Message-ID: <06ffd5cd-8b2a-4cd5-b74a-e6181ecc84b1@proxmox.com> Date: Tue, 28 Nov 2023 13:48:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pbs-devel@lists.proxmox.com References: <20231128094402.38115-1-d.csapak@proxmox.com> From: Philipp Hufnagl In-Reply-To: <20231128094402.38115-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 12:49:24 -0000 LGTM Tested-by: Philipp Hufnagl On 11/28/23 10:43, Dominik Csapak wrote: > and add a 'show information' window that includes the upload statistics. > This also moves some actions from the column directly into a 'hamburger > menu' so we don't overload the grid. > > The only downside to this currently is that i could get keyboard > navigation to work for the context menu or the hamburger menu, but i'm > still looking into this. > > This series replaces my old one for the upload statistics [0] > > > 0: https://lists.proxmox.com/pipermail/pbs-devel/2023-August/006343.html > > Dominik Csapak (5): > api-types: add an UploadStatistic api type > api: datastore admin: add 'snapshot-information' api call > ui: datastore content: add context menu to groups and snapshots > ui: datastore content: add snapshot information to context menu > ui: datastore content: add 'more actions' menu to actions > > pbs-api-types/src/datastore.rs | 36 +++++++ > src/api2/admin/datastore.rs | 117 +++++++++++++++++++-- > www/Makefile | 1 + > www/datastore/Content.js | 174 +++++++++++++++++++++++++++---- > www/window/SnapshotInfo.js | 182 +++++++++++++++++++++++++++++++++ > 5 files changed, 486 insertions(+), 24 deletions(-) > create mode 100644 www/window/SnapshotInfo.js >