From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 299BE61423
 for <pbs-devel@lists.proxmox.com>; Fri, 18 Feb 2022 15:10:31 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 1C2752A633
 for <pbs-devel@lists.proxmox.com>; Fri, 18 Feb 2022 15:10:31 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 2FCA42A613
 for <pbs-devel@lists.proxmox.com>; Fri, 18 Feb 2022 15:10:27 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 014A64629A
 for <pbs-devel@lists.proxmox.com>; Fri, 18 Feb 2022 15:10:21 +0100 (CET)
Message-ID: <06dcefe8-fc34-ad1f-3e97-f025de491b25@proxmox.com>
Date: Fri, 18 Feb 2022 15:10:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101
 Thunderbird/98.0
Content-Language: en-US
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, markus frank <m.frank@proxmox.com>
References: <20220218095538.2868974-1-m.frank@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220218095538.2868974-1-m.frank@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.058 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup] fix #3323: dry-run
 for cli backup subcommand
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 18 Feb 2022 14:10:31 -0000

On 18.02.22 10:55, markus frank wrote:
> From: Markus Frank <m.frank@proxmox.com>
> 
> adds a dry-run parameter for "proxmox-backup-client backup".
> With this parameter on it simply prints out what would be uploaded,
> instead of uploading it.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> version 2:
>  * tuple matching
>  * print closure
> 
>  proxmox-backup-client/src/main.rs | 50 +++++++++++++++++++++++++------
>  1 file changed, 41 insertions(+), 9 deletions(-)
> 
>

dropped one From header and applied, thanks!

Made two followups, one for the helper inline fn, i.e., repo was available in scope
so no need to pass it as param (question is if it's useful to repeat the same value
more than once anyway, but I kept it for now), and the second was for existing
non-ideal way the boolean/defaults where managed, the api macro is able to
handle that more comfortably and so that the default shows up in the CLI help.