From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 492821FF166 for ; Fri, 25 Oct 2024 12:42:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B44C1DE21; Fri, 25 Oct 2024 12:42:58 +0200 (CEST) Message-ID: <06374568-847b-4962-b524-b6761aa0bad5@proxmox.com> Date: Fri, 25 Oct 2024 12:42:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Christian Ebner References: <20241018084242.144010-1-c.ebner@proxmox.com> <20241018084242.144010-24-c.ebner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241018084242.144010-24-c.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v5 proxmox-backup 23/31] ui: sync: pass sync-direction to allow removing push jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" a bit high level, and sorry if i'm late to the party (maybe that was already asked in a previous iteration) why does the api call require the type to be given for it to be identified? AFAICS the jobs are in the same sectionconfig which share an id namespace anyway? if the api call would get the type automatically from the config, the parameter and this patch would vanish completely? On 10/18/24 10:42, Christian Ebner wrote: > Without the `sync-direction` parameter set, the job will not be > found in the config, because the `sync` config type is used instead > of the correct `sync-push` for sync jobs in push direction. > > Signed-off-by: Christian Ebner > --- > changes since version 4: > - no changes > > changes since version 3: > - no changes > > www/config/SyncView.js | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/www/config/SyncView.js b/www/config/SyncView.js > index 68a147615..981b9b251 100644 > --- a/www/config/SyncView.js > +++ b/www/config/SyncView.js > @@ -104,6 +104,26 @@ Ext.define('PBS.config.SyncJobView', { > }); > }, > > + removeSyncJob: function(btn, event, rec) { > + let me = this; > + let view = me.getView(); > + let params = {}; > + if (view.syncDirection !== undefined) { > + params["sync-direction"] = view.syncDirection; > + } > + Proxmox.Utils.API2Request({ > + url: '/config/sync/' + rec.getId(), > + method: 'DELETE', > + params: params, > + callback: function(options, success, response) { > + Ext.callback(me.callback, me.scope, [options, success, response, 0, me]); > + }, > + failure: function(response, opt) { > + Ext.Msg.alert(gettext('Error'), response.htmlStatus); > + }, > + }); > + }, > + > render_optional_owner: function(value, metadata, record) { > if (!value) return '-'; > return Ext.String.htmlEncode(value); > @@ -161,7 +181,7 @@ Ext.define('PBS.config.SyncJobView', { > }, > { > xtype: 'proxmoxStdRemoveButton', > - baseurl: '/config/sync/', > + handler: 'removeSyncJob', > confirmMsg: gettext('Remove entry?'), > callback: 'reload', > }, _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel