From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5EF1B1FF16F for ; Tue, 22 Jul 2025 08:22:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D19B23096B; Tue, 22 Jul 2025 08:24:07 +0200 (CEST) Message-ID: <05234c4b-785a-455c-9766-957469cc36b6@proxmox.com> Date: Tue, 22 Jul 2025 08:24:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20250721164507.1045869-1-c.ebner@proxmox.com> <20250721164507.1045869-28-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753165437009 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v10 24/46] ui: add s3 client edit window for configuration create/edit X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/21/25 10:14 PM, Thomas Lamprecht wrote: > Am 21.07.25 um 18:45 schrieb Christian Ebner: >> Adds an edit window for creating or editing S3 client configurations. >> Loosely based on the same edit window for the remote configuration. >> >> Signed-off-by: Christian Ebner >> --- >> changes since version 9: >> - no changes >> >> www/window/S3ClientEdit.js | 148 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 148 insertions(+) >> create mode 100644 www/window/S3ClientEdit.js >> >> diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js >> new file mode 100644 >> index 000000000..b22e920f8 >> --- /dev/null >> +++ b/www/window/S3ClientEdit.js >> @@ -0,0 +1,148 @@ > > --8<-- snip -->8-- > >> + getValues: function () { >> + let me = this; >> + let values = me.callParent(arguments); >> + >> + if (me.isCreate) { >> + /// Secrets are stored into separate config, but set the same id for both configs >> + values['secrets-id'] = values.id; >> + } > > The whole if above can be now dropped, one will actually get an error otherwise > when creating a new S3 client on the web UI. > > I can squash that in on applying if nothing else comes up. Good catch! Missed this when adapting the config api endpoint. While looking at the api again, I also noticed that there is no check whether the client is still configured for a datastore backend on remove, which will lead to a broken datastore. Will therefore resend the series with above if statement dropped and an additional in-use check for the client id. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel