From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id A90061FF17A
	for <inbox@lore.proxmox.com>; Tue, 11 Nov 2025 11:46:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id F40F06211;
	Tue, 11 Nov 2025 11:47:12 +0100 (CET)
Message-ID: <0455d5bd-fef5-4e7f-ab78-d31f4d6ab219@proxmox.com>
Date: Tue, 11 Nov 2025 11:46:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Christian Ebner <c.ebner@proxmox.com>
References: <20250916124147.513342-1-c.ebner@proxmox.com>
 <20250916124147.513342-9-c.ebner@proxmox.com>
Content-Language: en-US
From: Hannes Laimer <h.laimer@proxmox.com>
In-Reply-To: <20250916124147.513342-9-c.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1762857975042
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.046 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 4/4] ui: expose rate and
 burst limits for s3 endpoints
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>

On 9/16/25 14:42, Christian Ebner wrote:
> Allows to configure the s3 endpoints rate limits via the advanced
> options.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Changes since version 1:
> - no changes
> 
>   www/window/S3ClientEdit.js | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
> index 269b35967..8862683b8 100644
> --- a/www/window/S3ClientEdit.js
> +++ b/www/window/S3ClientEdit.js
> @@ -121,6 +121,20 @@ Ext.define('PBS.window.S3ClientEdit', {
>           ],
>   
>           advancedColumn1: [
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'rate-in',
> +                fieldLabel: gettext('Rate In'),
> +                emptyText: gettext('Unlimited'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'rate-out',
> +                fieldLabel: gettext('Rate Out'),
> +                emptyText: gettext('Unlimited'),
> +                submitAutoScaledSizeUnit: true,
> +            },
>               {
>                   xtype: 'proxmoxKVComboBox',
>                   name: 'provider-quirks',
> @@ -136,6 +150,22 @@ Ext.define('PBS.window.S3ClientEdit', {
>                   },
>               },
>           ],
> +        advancedColumn2: [
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'burst-in',
> +                fieldLabel: gettext('Burst In'),
> +                emptyText: gettext('Same as Rate'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'burst-out',
> +                fieldLabel: gettext('Burst Out'),
> +                emptyText: gettext('Same as Rate'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +        ],
>       },
>   
>       getValues: function () {
> @@ -146,6 +176,10 @@ Ext.define('PBS.window.S3ClientEdit', {
>               values.delete = values.delete.split(',');
>           }
>           PBS.Utils.delete_if_default(values, 'path-style', false, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'rate-in', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'burst-in', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'rate-out', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'burst-out', undefined, me.isCreate);
>   
>           let https_scheme_prefix = 'https://';
>           if (values.endpoint.startsWith(https_scheme_prefix)) {



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel