From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5924E617DC; Tue, 18 Aug 2020 19:50:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F3AB1661D; Tue, 18 Aug 2020 19:50:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1EAEF1660E; Tue, 18 Aug 2020 19:50:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D427F44672; Tue, 18 Aug 2020 19:50:09 +0200 (CEST) To: Proxmox VE development discussion , Hannes Laimer , pbs-devel@lists.proxmox.com References: <20200818084023.54780-1-h.laimer@proxmox.com> <20200818084023.54780-6-h.laimer@proxmox.com> From: Thomas Lamprecht Message-ID: <0289a632-3c04-8a97-6d82-b5834c268805@proxmox.com> Date: Tue, 18 Aug 2020 19:50:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200818084023.54780-6-h.laimer@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.280 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.567 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-backup 5/5] ui: added possiblity to remove directories/mount-units in the WebUI X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 17:50:11 -0000 Can I re-add the same one after wards? On 18.08.20 10:40, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/DirectoryList.js | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/www/DirectoryList.js b/www/DirectoryList.js > index 00531fd0..b4313e49 100644 > --- a/www/DirectoryList.js > +++ b/www/DirectoryList.js > @@ -20,6 +20,21 @@ Ext.define('PBS.admin.Directorylist', { > }, > }).show(); > }, > + removeDir: function () { > + let me = this; > + let view = me.getView(); > + let rec = view.getSelection(); could do let rec = me.getView().getSelection(); let id = rec[0].data.id; to avoid a only once used variable (they often can be OK, but here it adds no value when reading it) and instead avoid doing two 'rec[0].data.id' uses below. > + Ext.create('Proxmox.window.SafeRemove', { > + url: `/nodes/localhost/disks/directory/${rec[0].data.id}`, > + item: {type: 'Dir', id: rec[0].data.id}, please try to have new additions eslint compatible, i.e., item: { type: 'Dir', id: id, }, > + note: gettext('Data and partitions on the disk will be left untouched.'), did you checked available gettext translations for something which could be used here, to avoid a new translation? I'm fine with new ones, but only if there's really nothing which could be used. > + listeners: { > + destroy: function () { > + me.reload(); > + }, nit: could use arrow function: destroy: () => me.reload(), > + }, > + }).show(); > + }, > > reload: function() { > let me = this; > @@ -49,6 +64,13 @@ Ext.define('PBS.admin.Directorylist', { > text: gettext('Create') + ': Directory', > handler: 'createDirectory', > }, > + { > + xtype: 'proxmoxButton', > + text: gettext('Remove'), > + handler: 'removeDir', > + disabled: true, > + iconCls: 'fa fa-trash-o' > + } > ], > > columns: [ >