From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8DEE07161A for <pbs-devel@lists.proxmox.com>; Thu, 12 May 2022 11:53:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7CA6E253F5 for <pbs-devel@lists.proxmox.com>; Thu, 12 May 2022 11:53:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9B00253EA for <pbs-devel@lists.proxmox.com>; Thu, 12 May 2022 11:53:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8AF8E42904 for <pbs-devel@lists.proxmox.com>; Thu, 12 May 2022 11:53:24 +0200 (CEST) Message-ID: <02887f82-ed5e-d5fc-e780-afed21ea7ede@proxmox.com> Date: Thu, 12 May 2022 11:53:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> References: <20220504054906.9218-1-h.laimer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220504054906.9218-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] proxy: rrd: skip update disk stats for offline datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 12 May 2022 09:53:57 -0000 Am 5/4/22 um 07:49 schrieb Hannes Laimer: > RDD update did not use lookup_datastore() and therefore bypassed > the maintenance mode checks. This adds the needed check directly. > > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com> > --- > src/bin/proxmox-backup-proxy.rs | 6 ++++++ > 1 file changed, 6 insertions(+) > > applied, thanks! But there was a similar issue in the schedule_datastore_garbage_collection fn, which tried to look up the Datastore with a Write operation at the very start, before even checking if GC for that store is scheduled at all and if it would be pending now, and the actual problematic check if GC is already running (which needs a datastore instance, so just moving the lookup code downward couldn't be the single solution). For that I added a new Lookup operation in a limited scope, and then open the datastore with the Write op only directly before actually wanting to start GC, at which point a log entry is ok.