From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56DD5BBD07 for ; Tue, 19 Dec 2023 14:25:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 32BF037EFD for ; Tue, 19 Dec 2023 14:25:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Dec 2023 14:25:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 70ACF485C0 for ; Tue, 19 Dec 2023 14:25:19 +0100 (CET) Message-ID: <01fe6481-7cfa-477a-936d-34e9d3b71ce2@proxmox.com> Date: Tue, 19 Dec 2023 14:25:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Philipp Hufnagl References: <20231218153638.609440-1-p.hufnagl@proxmox.com> From: Lukas Wagner In-Reply-To: <20231218153638.609440-1-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v5 0/4] fix #4315: datastore: Exclude entries from sync X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2023 13:25:50 -0000 On 12/18/23 16:36, Philipp Hufnagl wrote: > This allows to use Group Filter for sync jobs so matches can not just be > included but also excluded. For this the "group-filter" configuration > syntax has been extended with an optional "behaviour" parameter. > this can be "include" or "exclude". First, all include filter will be > applied, then all exclude filter. If no include filters exist, all will > be considered included. > > Signed-off-by: Philipp Hufnagl > --- > > Changes since v4: > * add testing > * refactor apply filter logic to reduce duplicaton > * split filter in incude/exclude lists > Gave this another test on the latest master, now the issue with only include filters is fixed. There are some minor issues in the code that I would like to see fixed before this goes in. -- - Lukas