From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 1A7201FF37F
	for <inbox@lore.proxmox.com>; Tue, 18 Jun 2024 13:41:32 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 493561889F;
	Tue, 18 Jun 2024 13:41:35 +0200 (CEST)
Message-ID: <01d2ebe6-706e-4b8f-8b4a-d351423b9874@proxmox.com>
Date: Tue, 18 Jun 2024 13:41:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Friedrich Weber <f.weber@proxmox.com>,
 Gabriel Goller <g.goller@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20240614093940.149087-1-g.goller@proxmox.com>
 <c4d28f1d-bc85-46c4-bc5b-f4aa61b5051c@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <c4d28f1d-bc85-46c4-bc5b-f4aa61b5051c@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.026 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] client: mount: flush
 output before exiting
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 6/18/24 13:20, Friedrich Weber wrote:
> Thanks for tackling this! I ran into this issue (sometimes missing error
> output) when I was running `sudo proxmox-backup-client mount [...]` and
> forgot that PBS_REPOSITORY was not passed through by sudo. It looks like
> in this case, the patch doesn't completely fix this issue -- seems like
> I'm still missing the error output sometimes:
> 
> $ sudo ./proxmox-backup-client mount \
>          "$SNAPSHOT" $FILE $PATH \
>          --keyfile $KEYFILE --ns $NS
> $ sudo ./proxmox-backup-client mount \
>          "$SNAPSHOT" $FILE $PATH \
>          --keyfile $KEYFILE --ns $NS
> $ sudo ./proxmox-backup-client mount \
>          "$SNAPSHOT" $FILE $PATH \
>          --keyfile $KEYFILE --ns $NS
> Error: unable to get (default) repository

Hi Friedrich,
I just double checked by invoking the command in a for loop 10 times, 
for all of which I do get the error message as output.

```bash
for i in $(seq 0 9)
do
	sudo proxmox-backup-client mount ct/100/2024-06-13T10:38:54Z root.pxar /mnt
done
```

Interestingly, I do also get the output without the patch applied, so 
therefore I did not notice (and obviously forgot to do the negative test 
during review).

Maybe some difference in setup?

Cheers,
Chris


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel