From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id DF8BC1FF172
for <inbox@lore.proxmox.com>; Wed, 23 Apr 2025 11:40:52 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6A696E37E;
Wed, 23 Apr 2025 11:40:50 +0200 (CEST)
Date: Wed, 23 Apr 2025 11:40:16 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Message-ID: <zx2hepix3b4obc2xmcmu4xszswbrkw3doqwpeqxono5d35tjbi@yrk64bqut2bf>
Mail-Followup-To: Wolfgang Bumiller <w.bumiller@proxmox.com>,
pdm-devel@lists.proxmox.com
References: <20250414120046.486853-1-g.goller@proxmox.com>
<20250414120046.486853-3-g.goller@proxmox.com>
<rkrv5u6dcpwgwu7vqrlttrrntwp3c7jwqvdv4adcovtxpwkczb@rqw3suoyoqoz>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <rkrv5u6dcpwgwu7vqrlttrrntwp3c7jwqvdv4adcovtxpwkczb@rqw3suoyoqoz>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH proxmox 2/3] section-config: remove DerefMut
and make underlying HashMap private
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
On 15.04.2025 10:29, Wolfgang Bumiller wrote:
>1 minor thing...
>
>On Mon, Apr 14, 2025 at 02:00:44PM +0200, Gabriel Goller wrote:
>> [snip]
>> + /// Remove a key-value pair from the section config.
>> + ///
>> + /// If the key existed and was removed, also remove the key from the order vector
>> + /// to maintain ordering consistency.
>> + ///
>> + /// # Returns
>> + ///
>> + /// * `Some(value)` - If the key was present, returns the value that was removed
>> + /// * `None` - If the key was not present
>> + pub fn remove(&mut self, key: &str) -> Option<T> {
>> + let removed_value = self.sections.remove(key);
>> + // only update the order vector if we actually removed something
>> + if removed_value.is_some() {
>> + self.order.retain(|k| k != key);
>
>`retain()` always goes through the entire vector. We don't typically
>have large numbers of sections, so, not that bad, butin general I do
>lean more towards
>
> if let Some(pos) = vec.iter().position(|k| k == key) {
> vec.remove(pos);
> }
>
>when we know there should only be at most 1 such element
Yup, we can guarantee that AFAIK.
Fixed it.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel