Re: [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers

Gabriel Goller
2026-05-08T11:31:25Z

On 07.05.2026 13:23, Daniel Herzig wrote:
> This patch addresses the incorrect application of the original
> vmid to cloned containers in pve ipams, which results in duplicate
> vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint.
>
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>

LGTM, Consider:

Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

> ---
> THX @Gabriel for the offline input.
>
> src/PVE/API2/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 838dd76..89d8a53 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({
> my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1);
>
> eval {
> - PVE::LXC::create_ifaces_ipams_ips($conf, $vmid);
> + PVE::LXC::create_ifaces_ipams_ips($conf, $newid);
> my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
> $lxc_setup->post_clone_hook($conf);
> };
> --
> 2.47.3