From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0A3131FF179 for ; Wed, 29 Oct 2025 15:06:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBFAACA18; Wed, 29 Oct 2025 15:06:55 +0100 (CET) Date: Wed, 29 Oct 2025 15:06:21 +0100 From: Wolfgang Bumiller To: Christian Ebner Message-ID: References: <20251029100958.309086-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251029100958.309086-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761746768940 X-SPAM-LEVEL: Spam detection results: 1 AWL -2.799 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SOMETLD_ARE_BAD_TLD 5 .bar, .beauty, .buzz, .cam, .casa, .cfd, .club, .date, .guru, .link, .live, .monster, .online, .press, .pw, .quest, .rest, .sbs, .shop, .stream, .top, .trade, .wiki, .work, .xyz TLD abuse PDS_OTHER_BAD_TLD 0.75 Untrustworthy TLDs RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote: > The PBS datastore panel currently mixes status information > (maintenance, usage, ...) with datastore properties (removable, s3). > Since the latter will not change, and the dashboard panels are more > intended to show current status information, drop the removable and > s3 columns. The search filters remain unaffected by this, still > allowing to filter PBS datastored by these. Is there another place where we already see this? Or is something planned? I'm just wondering where else this would make sense. > > Signed-off-by: Christian Ebner > --- > ui/src/dashboard/pbs_datastores_panel.rs | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs > index 3e148e6..a06acf7 100644 > --- a/ui/src/dashboard/pbs_datastores_panel.rs > +++ b/ui/src/dashboard/pbs_datastores_panel.rs > @@ -40,8 +40,6 @@ impl From for VNode { > pub enum StatusRow { > Online(u64), > UnderMaintenance(u64), > - Removable(u64), > - S3Backend(u64), > HighUsage(u64), > Unknown(u64), > All(u64), > @@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent { > let data = vec![ > StatusRow::Online(status.online), > StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()), > - StatusRow::Removable(status.removable.unwrap_or_default()), > - StatusRow::S3Backend(status.s3_backend.unwrap_or_default()), > StatusRow::HighUsage(status.high_usage.unwrap_or_default()), > StatusRow::Unknown(status.unknown.unwrap_or_default()), > StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()), > @@ -121,18 +117,6 @@ fn create_list_tile( > "Under Maintenance", > Some(("under-maintenance", "status")), > ), > - StatusRow::Removable(count) => ( > - Fa::new("plug"), > - count, > - "Removable", > - Some(("removable", "property")), > - ), > - StatusRow::S3Backend(count) => ( > - Fa::new("cloud-upload"), > - count, > - "S3", > - Some(("s3", "property")), > - ), > StatusRow::Unknown(count) => ( > Fa::from(Status::Unknown), > count, > -- > 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel