From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 0FD011FF172
for <inbox@lore.proxmox.com>; Wed, 23 Apr 2025 13:46:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 2E043190D2;
Wed, 23 Apr 2025 13:46:50 +0200 (CEST)
Date: Wed, 23 Apr 2025 13:46:16 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Message-ID: <z6xoalxyyekii6uiq2jczyaw6lp7e34nza557qowsju2lh7i7q@v7neadpkerd7>
Mail-Followup-To: Stefan Hanreich <s.hanreich@proxmox.com>,
pve-devel@lists.proxmox.com
References: <20250414154455.274151-1-s.hanreich@proxmox.com>
<20250414154455.274151-3-s.hanreich@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250414154455.274151-3-s.hanreich@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox-firewall 2/2] firewall: add
subcommands to proxmox-firewall binary
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 14.04.2025 17:44, Stefan Hanreich wrote:
> [snip]
>+fn main() -> Result<(), Error> {
>+ let mut args = Arguments::from_env();
>+
>+ let parsed_command = args.subcommand()?
>+ .ok_or_else(|| format_err!("no subcommand specified"))?
Maybe we could print HELP here again? So that you don't have to guess
the subcommands.
>+ .parse();
>+
>+ if let Ok(command) = parsed_command {
>+ run_command(command)
>+ } else {
>+ eprintln!("Invalid command specified!\n{}", HELP);
>+ std::process::exit(1);
>+ }
>+
>+}
Also this file needs a `cargo fmt` :)
Otherwise the whole series looks good, consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel