From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 389D51FF17C for ; Wed, 3 Sep 2025 09:54:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CAFF82BF25; Wed, 3 Sep 2025 09:54:23 +0200 (CEST) Date: Wed, 3 Sep 2025 09:53:50 +0200 From: Wolfgang Bumiller To: Dominik Csapak Message-ID: References: <20250828131832.4058422-1-d.csapak@proxmox.com> <20250828131832.4058422-2-d.csapak@proxmox.com> <2b468b24-6535-4422-b00d-15ba63827026@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2b468b24-6535-4422-b00d-15ba63827026@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756886015417 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [resource.rs] Subject: Re: [pdm-devel] [PATCH datacenter-manager v4 01/10] pdm-api-types: resources: add helper methods for fields X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Wed, Sep 03, 2025 at 09:38:22AM +0200, Dominik Csapak wrote: > > > On 9/2/25 4:29 PM, Wolfgang Bumiller wrote: > > On Thu, Aug 28, 2025 at 03:16:00PM +0200, Dominik Csapak wrote: > > > namely 'resource_type' and 'status'. All resources have those fields > > > in one way or another, so adding a helper that one does not have to > > > use `match` on every call site makes code there shorter. > > > > > > Signed-off-by: Dominik Csapak > > > --- > > > no changes in v4 > > > lib/pdm-api-types/src/resource.rs | 27 +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > > > diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs > > > index 6227855..0dfadd5 100644 > > > --- a/lib/pdm-api-types/src/resource.rs > > > +++ b/lib/pdm-api-types/src/resource.rs > > > @@ -62,6 +62,33 @@ impl Resource { > > > Resource::PbsDatastore(r) => r.name.as_str(), > > > } > > > } > > > + > > > + pub fn resource_type(&self) -> &str { > > > > ^ This may be nicer as simple `enum` with a `Display`/`FromStr` > > implementation. > > > > mhmm the only use i have of that currently would it make harder to use with > a separate enum > (also we'd copy the type with `to_string()` once more) > > e.g. i use > > `resource.resource_type().starts_with(...)` > > with a separate enum it would be > > `resource.resource_type().to_string().starts_with(...)` > > which is more to write and one string copy extra... The enum would just have a `fn as_str(&self) -> &'static str`... (Btw. many of these could probably be explicitly `'static`) But it's not that important for now... > > > > + match self { > > > + Resource::PveStorage(_) => "storage", > > > + Resource::PveQemu(_) => "qemu", > > > + Resource::PveLxc(_) => "lxc", > > > + Resource::PveNode(_) | Resource::PbsNode(_) => "node", > > > + Resource::PbsDatastore(_) => "datastore", > > > + } > > > + } > > > + > > > + pub fn status(&self) -> &str { > > > + match self { > > > + Resource::PveStorage(r) => r.status.as_str(), > > > + Resource::PveQemu(r) => r.status.as_str(), > > > + Resource::PveLxc(r) => r.status.as_str(), > > > + Resource::PveNode(r) => r.status.as_str(), > > > + Resource::PbsNode(r) => { > > > + if r.uptime > 0 { > > > + "online" > > > + } else { > > > + "offline" > > > + } > > > + } > > > + Resource::PbsDatastore(_) => "online", > > > + } > > > + } > > > } > > > #[api( > > > -- > > > 2.47.2 > _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel