From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 397B91FF17C for ; Wed, 2 Apr 2025 12:04:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7B7DE85E; Wed, 2 Apr 2025 12:04:13 +0200 (CEST) Date: Wed, 2 Apr 2025 12:04:10 +0200 From: Gabriel Goller To: Friedrich Weber Message-ID: Mail-Followup-To: Friedrich Weber , Proxmox VE development discussion References: <20250328171340.885413-1-g.goller@proxmox.com> <20250328171340.885413-47-g.goller@proxmox.com> <10d13687-98a9-4625-8e1a-8fe519171e07@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10d13687-98a9-4625-8e1a-8fe519171e07@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager 2/7] fabrics: add common interface panel X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 02.04.2025 11:26, Friedrich Weber wrote: >> + commonColumns: [ >> + { >> + text: gettext('Status'), >> + dataIndex: 'status', >> + width: 30, >> + renderer: function(value, metaData, record) { >> + let icon = record.data.statusIcon || ''; >> + let tooltip = record.data.statusTooltip || ''; >> + >> + if (tooltip) { >> + metaData.tdAttr = 'data-qtip="' + Ext.htmlEncode(tooltip) + '"'; >> + } > >Tooltips need to be double-encoded [1], so one htmlEncode might be missing here. > >[1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f08f08a042cec0124f73199dcda0d8f882e14507 Ah, so: metaData.tdAttr = 'data-qtip="' + Ext.htmlEncode(Ext.htmlEncode(tooltip)) + '"'; ? Thanks for the review! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel