Re: [PATCH proxmox v3 01/23] Add oauth2 and ureq to workspace dependencies

Lukas Wagner
2026-04-21T08:12:34Z

Hi Arthur!

Two notes inline, looks good otherwise.

On Wed Apr 15, 2026 at 9:01 AM CEST, Arthur Bied-Charreton wrote:
> Since oauth2 and ureq will be needed by proxmox-notify for XOAUTH2
> support, pull them in as workspace dependencies and update
> proxmox-openid and proxmox-http accordingly.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
> Cargo.toml | 2 ++
> proxmox-http/Cargo.toml | 2 +-
> proxmox-openid/Cargo.toml | 2 +-
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Cargo.toml b/Cargo.toml
> index cf49a8b0..ecc36d65 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -119,6 +119,7 @@ nix = "0.29"
> nom = "7"
> # used by proxmox-disks, can be replaced by OnceLock from std once it supports get_or_try_init
> once_cell = "1.3.1"
> +oauth2 = { version = "5", default-features = false }
> openssl = "0.10"
> pam-sys = "0.5"
> percent-encoding = "2.1"
> @@ -148,6 +149,7 @@ tracing-journald = "0.3.1"
> tracing-log = { version = "0.2", default-features = false }
> tracing-subscriber = "0.3.16"
> udev = "0.9"
> +ureq = { version = "3", default-features = false }
> url = "2.2"
> walkdir = "2"
> zstd = "0.13"
> diff --git a/proxmox-http/Cargo.toml b/proxmox-http/Cargo.toml
> index 66b11650..c1240fdf 100644
> --- a/proxmox-http/Cargo.toml
> +++ b/proxmox-http/Cargo.toml
> @@ -27,7 +27,7 @@ sync_wrapper = { workspace = true, optional = true }
> tokio = { workspace = true, features = [], optional = true }
> tokio-openssl = { workspace = true, optional = true }
> tower-service = { workspace = true, optional = true }
> -ureq = { version = "3.0", features = ["native-tls"], optional = true, default-features = false }
> +ureq = { version = "3.0", features = ["native-tls"], optional = true, default-features = false, workspace = true }

You should drop the 'version' key when using it as a workspace
dependency -- the main point of using a workspace dep is using the same
version in the entire workspace, after all :)

> url = { workspace = true, optional = true }
>
> proxmox-async = { workspace = true, optional = true }
> diff --git a/proxmox-openid/Cargo.toml b/proxmox-openid/Cargo.toml
> index 5b031800..aed788d7 100644
> --- a/proxmox-openid/Cargo.toml
> +++ b/proxmox-openid/Cargo.toml
> @@ -22,7 +22,7 @@ thiserror.workspace = true
> native-tls.workspace = true
>
> openidconnect = { version = "4", default-features = false, features = ["accept-rfc3339-timestamps"] }
> -ureq = { version = "3", default-features = false, features = ["native-tls", "gzip"] }
> +ureq = { version = "3", default-features = false, features = ["native-tls", "gzip"], workspace = true }

same here

>
> proxmox-time.workspace = true
> proxmox-sys = { workspace = true, features = ["timer"] }