From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH pve-firewall v2] api: aliases: make 'cidr' optional when updating
Date: Thu, 15 Oct 2026 07:46:46 +0200 [thread overview]
Message-ID: <vef4mrh2hqyo2udcipw54g3m4s6nkypj2wxnimlwgvcxzdgr75@6vamqdaloeaf> (raw)
In-Reply-To: <179199180896.318505.14249674297284436098.b4-review@b4>
On Wed, Oct 14, 2026 at 05:30:08PM +0200, Stefan Hanreich wrote:
> > @@ -251,7 +251,10 @@ sub register_update_alias {
> >
> > raise_param_exc({ name => "no such alias" }) if !$aliases->{$name};
> >
> > - my $data = { name => $param->{name}, cidr => $param->{cidr} };
> > + my $data = {
> > + name => $param->{name},
> > + cidr => $param->{cidr} // $aliases->{$name}->{cidr},
> > + };
> > $data->{comment} = $param->{comment} if $param->{comment};
>
> The comment here gets overwritten when updating the cidr, also when
> renaming.
>
true, thanks for noticing that!
superseded by:
https://lore.proxmox.com/pve-devel/20261015054534.25978-1-a.bied-charreton@proxmox.com/T/#u
> --
> Stefan Hanreich <s.hanreich@proxmox.com>
prev parent reply other threads:[~2026-10-15 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 13:25 [PATCH pve-firewall v2] api: aliases: make 'cidr' optional when updating Arthur Bied-Charreton
2026-10-14 15:30 ` Stefan Hanreich
2026-10-15 5:46 ` Arthur Bied-Charreton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vef4mrh2hqyo2udcipw54g3m4s6nkypj2wxnimlwgvcxzdgr75@6vamqdaloeaf \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.