From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9B4261FF172 for ; Wed, 23 Apr 2025 11:45:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8B3DE994; Wed, 23 Apr 2025 11:45:01 +0200 (CEST) Date: Wed, 23 Apr 2025 11:44:29 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: Mail-Followup-To: Wolfgang Bumiller , pdm-devel@lists.proxmox.com References: <20250414120046.486853-1-g.goller@proxmox.com> <20250414120046.486853-3-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox 2/3] section-config: remove DerefMut and make underlying HashMap private X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 15.04.2025 10:42, Wolfgang Bumiller wrote: >On Mon, Apr 14, 2025 at 02:00:44PM +0200, Gabriel Goller wrote: >> [snip] >> + /// Insert a key-value pair in the section config. >> + /// >> + /// If the key does not exist in the map, it will be added to the end of >> + /// the order vector. >> + /// >> + /// # Returns >> + /// >> + /// * Some(value) - If the key was present, returns the previous value >> + /// * None - If the key was not present >> + pub fn insert(&mut self, key: String, value: T) -> Option { > >Oh btw. this could be an `impl Into` (or generic), that way we >can at least avoid *some* double-clones... > Agree! >> + let previous_value = self.sections.insert(key.clone(), value); >> + // If there was no previous value, this is a new key, so add it to the order >> + if previous_value.is_none() { >> + self.order.push(key); >> + } >> + previous_value >> + } _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel