all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes
Date: Tue, 28 Jul 2026 14:05:17 +0200	[thread overview]
Message-ID: <twgwyov5atycyb7ro6rrvekot42mxxlaydsojpq2er44ywilo4@bscucdlvq33g> (raw)
In-Reply-To: <20260728085208.33679-1-f.ebner@proxmox.com>

On Tue, Jul 28, 2026 at 10:52:00AM +0200, Fiona Ebner wrote:
> Avoid confusion for users who are not familiar with the terms [0].
> Especially TCG is not that well-known.
> 
> [0]: https://forum.proxmox.com/threads/185360/
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/form/VMCPUFlagSelector.js | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index aadd8b88..b51731aa 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -292,8 +292,21 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>                          xtype: 'segmentedbutton',
>                          allowMultiple: false,
>                          items: [
> -                            { text: 'KVM', value: 1, pressed: true },
> -                            { text: 'TCG', value: 0 },
> +                            {
> +                                text: 'KVM',
> +                                value: 1,
> +                                pressed: true,
> +                                tooltip: gettext(
> +                                    'Hardware-accelerated virtualization (fast, recommended)',
> +                                ),
> +                            },
> +                            {
> +                                text: 'TCG',
> +                                value: 0,
> +                                tooltip: gettext(
> +                                    'Software emulation (slow, needed for cross-architecture emulation)',
> +                                ),
> +                            },
>                          ],
>                          listeners: {
>                              change: function (field, value) {
> -- 
> 2.47.3
> 
> 
Thanks for this, good addition and works as advertised. 

Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>




  reply	other threads:[~2026-07-28 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  8:52 [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes Fiona Ebner
2026-07-28 12:05 ` Arthur Bied-Charreton [this message]
2026-07-28 12:18 ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=twgwyov5atycyb7ro6rrvekot42mxxlaydsojpq2er44ywilo4@bscucdlvq33g \
    --to=a.bied-charreton@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal