From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager v5 2/2] fix #5475: configurable window title
Date: Thu, 24 Sep 2026 14:00:58 +0200 [thread overview]
Message-ID: <szh6zpafazqaqda6t5hwdydbfiydhbwjmptvw2eb6fnangu6ye@e3iffkkmekpc> (raw)
In-Reply-To: <20260924095251.143579-3-t.ellmenreich@proxmox.com>
On Thu, Sep 24, 2026 at 11:52:51AM +0200, Thomas Ellmenreich wrote:
> Added a new 'ui-settings' format string to the datacenter.cfg which now
> has a 'title' option to configure the browser tab title for pve tabs.
>
> Adjusted the index.html templating to construct the correct window title
> on every request according to the cluster configuration.
> [...]
lgtm!
Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
prev parent reply other threads:[~2026-09-24 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 9:52 [PATCH cluster/manager v5 0/2] Configurable window titles for nodes Thomas Ellmenreich
2026-09-24 9:52 ` [PATCH cluster v5 1/2] fix #5475: configurable window title Thomas Ellmenreich
2026-09-24 12:01 ` Arthur Bied-Charreton
2026-09-24 9:52 ` [PATCH manager v5 2/2] " Thomas Ellmenreich
2026-09-24 12:00 ` Arthur Bied-Charreton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=szh6zpafazqaqda6t5hwdydbfiydhbwjmptvw2eb6fnangu6ye@e3iffkkmekpc \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.