From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 773391FF185 for ; Mon, 17 Nov 2025 14:10:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E88BB18992; Mon, 17 Nov 2025 14:10:59 +0100 (CET) Date: Mon, 17 Nov 2025 14:10:26 +0100 From: Gabriel Goller To: Thomas Lamprecht Message-ID: Mail-Followup-To: Thomas Lamprecht , Proxmox VE development discussion References: <20250527140446.365983-1-g.goller@proxmox.com> <20250527140446.365983-3-g.goller@proxmox.com> <690d6786-f70a-41e7-b231-d064c2d6f6dd@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <690d6786-f70a-41e7-b231-d064c2d6f6dd@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763384997752 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH pve-manager v5 2/2] guest: refactor and reuse AgentIPView for containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 15.11.2025 18:16, Thomas Lamprecht wrote: > Am 27.05.25 um 16:04 schrieb Gabriel Goller: > > Refactor AgentIPView to be generic over container and vms. Reuse it in > > the Container Summary to show the ip addresses of the container. Also > > make the GuestSummary scrollable, as it can potentially be bigger > > (because of the ip-addresses that can be shown) than 300 (which is the > > size of the RRD graphs). > > > > Signed-off-by: Gabriel Goller > > --- > > www/manager6/Makefile | 2 +- > > www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++- > > www/manager6/panel/GuestSummary.js | 1 + > > .../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++-------- > > 4 files changed, 151 insertions(+), 71 deletions(-) > > rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%) > > > > > > I rechecked the changes and I disliked the callback approach, so I reworked > this to rather using a base class and two specialized sub-classes, one for > VMs and one for CTs. This encapsulates underlying details better, one that > instantiates these widgets somewhere should not have to care about (plus > doing so crowds the use-sites code). > > That said, your changes itself where quite well structured, so adapting it > wasn't much of a hassle, besides one ExtJS bug (IMO) getting in my way > quite a bit, see another follow-up for some more info on that though. > . Thanks for tackling this! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel