From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 45B221FF138
	for <inbox@lore.proxmox.com>; Wed, 04 Feb 2026 14:50:18 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 53B431537F;
	Wed,  4 Feb 2026 14:50:50 +0100 (CET)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH proxmox-i18n 2/2] fix strings with wrong format
In-Reply-To: <s8o4inw39ql.fsf@proxmox.com> (Maximiliano Sandoval's message of
	"Wed, 04 Feb 2026 14:43:14 +0100")
References: <20260204104150.178904-1-m.sandoval@proxmox.com>
	<20260204104150.178904-2-m.sandoval@proxmox.com>
	<s8o4inw39ql.fsf@proxmox.com>
User-Agent: mu4e 1.12.9; emacs 30.1
Date: Wed, 04 Feb 2026 14:50:15 +0100
Message-ID: <s8oy0l81uug.fsf@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1770212938982
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.088 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 7YD4VWXRV2CGK75XUP5XTHD4R7ZF2HQD
X-Message-ID-Hash: 7YD4VWXRV2CGK75XUP5XTHD4R7ZF2HQD
X-MailFrom: m.sandoval@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>
>> That would fail to be replaced at runtime. Depending on how the string
>> was replaced at runtime having a broken format can result in either the
>> string not being replaced at runtime or a crash.
>>
>> ...
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
> I found more issues on strings consumed by js. I will send v2 in a bit.

Superseded-by: https://lore.proxmox.com/all/20260204134835.422155-1-m.sandoval@proxmox.com/

-- 
Maximiliano