From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 050B81FF165 for ; Thu, 23 Oct 2025 15:23:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BADEAFEE; Thu, 23 Oct 2025 15:24:00 +0200 (CEST) From: Maximiliano Sandoval To: Shannon Sterz In-Reply-To: <20251023080013.40452-1-s.sterz@proxmox.com> (Shannon Sterz's message of "Thu, 23 Oct 2025 10:00:13 +0200") References: <20251023080013.40452-1-s.sterz@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 23 Oct 2025 15:23:57 +0200 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761225829225 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [yew-devel] [PATCH yew-comp] token panel: ask for confirmation when removing a token X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Cc: yew-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" Shannon Sterz writes: > by using a `ConfirmButton` instead of just a `Button`. > > Signed-off-by: Shannon Sterz > --- > src/token_panel.rs | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/token_panel.rs b/src/token_panel.rs > index 55795a6..d61063a 100644 > --- a/src/token_panel.rs > +++ b/src/token_panel.rs > @@ -190,7 +190,9 @@ impl LoadableComponent for ProxmoxTokenView { > .on_activate(link.change_view_callback(|_| Some(ViewState::EditToken))), > ) > .with_child( > - Button::new(tr!("Remove")) > + ConfirmButton::new(tr!("Remove")) > + .confirm_message(tr!("Are you sure you want to remove the API token? \ > + All current usage sites will lose access!")) I know this label is used already in other places and this is pre-existing, but I am not sure if "usage sites" is easy to understand. Perhaps something along the lines of "All users of the token will lose access" is more straightforward. > .disabled(disabled) > .on_activate(link.callback(|_| Msg::Remove)), > ) -- Maximiliano _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel