From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F14341FF183 for ; Wed, 27 Aug 2025 10:40:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1C3313E42; Wed, 27 Aug 2025 10:40:28 +0200 (CEST) From: Maximiliano Sandoval To: Thomas Lamprecht In-Reply-To: <917c568b-5a3d-466d-bbfb-87c20930e765@proxmox.com> (Thomas Lamprecht's message of "Tue, 26 Aug 2025 23:58:19 +0200") References: <20250813124347.452585-1-m.sandoval@proxmox.com> <917c568b-5a3d-466d-bbfb-87c20930e765@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 27 Aug 2025 10:40:25 +0200 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756284020393 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.101 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Thomas Lamprecht writes: > On 13/08/2025 14:43, Maximiliano Sandoval wrote: >> In a support case we found a system with 40:00 as a schedule in a backup job. It >> is possible to entire this calendar event on the web UI. >> >> As per systemd-analize: >> >> ``` >> $ systemd-analyze calendar 40:00 >> Failed to parse calendar specification '40:00': Invalid argument >> ``` >> >> After this series the Proxmox VE web UI won't allow it anymore with an error: >> >> ``` >> Parameter verification failed. (400) >> >> schedule: invalid format - invalid calendar event '40:00' - unable to parse calendar event at ':00' - Nom(Eof) >> ``` >> > > What about the backward compat concerns from Dominik and Fiona, I see > nothing written anywhere in this series addressing them, or did I just > overlooked that? > > Could we treat only serializing strict and deserializing not? I am not sure if it is possible or something we do in general. We would need to be strict when de-serializing from the web UI (to prevent wrong entries from reaching the configuration file) but be more lenient when de-serializing from the configuration file. >> Differences from v1: >> - Add cover letter >> - Reference bugzilla entry #6161 >> - Add test case for 24:00 as per #6161 >> >> Maximiliano Sandoval (3): >> time: Add traits to DateTimeValue and TimeSpec >> fix #6161: time: Split parse_time_spec parser into two >> time: Add more calendat event tests >> >> proxmox-time/src/calendar_event.rs | 109 ++++++++++++++++++++++++++-- >> proxmox-time/src/date_time_value.rs | 2 +- >> 2 files changed, 103 insertions(+), 8 deletions(-) >> -- Maximiliano _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel