From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1698F1FF165 for ; Thu, 23 Oct 2025 16:51:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 29D89D266; Thu, 23 Oct 2025 16:51:53 +0200 (CEST) From: Maximiliano Sandoval To: Hannes Duerr In-Reply-To: <20251023141314.98563-1-h.duerr@proxmox.com> (Hannes Duerr's message of "Thu, 23 Oct 2025 16:13:14 +0200") References: <20251023141314.98563-1-h.duerr@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 23 Oct 2025 16:51:50 +0200 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761231102102 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] report: better hardware and system utilization overview. X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Hannes Duerr writes: > instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command > `ls -l /dev/disk/by-*` is beeing used which displays the discs not only > by-id and by-path, but also by-diskseq, by-label, by-uuid, and > by-partuuid, which can be very helpful when assigning iSCSI and > multipath devices. > > `dmidecode -t bios` outputs the current BIOS version and which allows to > determine whether certain fixes have already been implemented in the > version or not. > > `lscpu` provides a good overview of the CPU being used, its flags, and > existing/non-existing mitigations. > > `lspci -nnk` displays all PCI devices and the drivers used, which is often > helpful when troubleshooting. > > `ip -details -statistics a` provides a detailed overview of the > available interfaces and statistics since the last boot. This > information is often helpful in addressing performance issues and > assessments. > > Signed-off-by: Hannes Duerr > --- > src/server/report.rs | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/server/report.rs b/src/server/report.rs > index ca5f04fc..64a209ec 100644 > --- a/src/server/report.rs > +++ b/src/server/report.rs > @@ -82,10 +82,14 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> { > "+HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN", > ], > ), > - ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]), > + ("ls", vec!["-l", "/dev/disk/by-*"]), > ("zpool", vec!["status"]), > ("zfs", vec!["list"]), > ("arcstat", vec![]), > + ("dmidecode", vec!["-t", "bios"]), > + ("lscpu", vec![]), > + ("lspci", vec!["-nnk"]), > + ("ip", vec!["-details", "-statistics", "a"]), > ] > } I tested this patch and the report contains: `````` $ `ls -l /dev/disk/by-*` ``` ``` STDERR: ``` ls: cannot access '/dev/disk/by-*': No such file or directory ``` `````` perhaps we cannot use a glob pattern in this environment? Note that the command runs just fine with bash (over ssh) on the machine where this was tested. Other than that, this would be an excellent addition. Tested-by: Maximiliano Sandoval Reviewed-by: Maximiliano Sandoval -- Maximiliano _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel