From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E5F951FF138 for ; Wed, 04 Mar 2026 09:35:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4CC0F326E; Wed, 4 Mar 2026 09:36:50 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: superseded: [PATCH ha-manager v2] resources: Expand max_restart option In-Reply-To: <20260303132206.222398-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Tue, 3 Mar 2026 14:22:05 +0100") References: <20260303132206.222398-1-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 04 Mar 2026 09:36:44 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772613379317 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SKIUVPEG3X4ZTXZDLPUSJA26KUMHU72G X-Message-ID-Hash: SKIUVPEG3X4ZTXZDLPUSJA26KUMHU72G X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > When read next to `max_relocate` it is not clear which happens first > after a service fails to start. > > Signed-off-by: Maximiliano Sandoval > > --- > > Differences from v1: > - Incorporate feedback. Namely, "the service will be attempted to be relocated" > was a bit too convoluted. > > src/PVE/HA/Resources.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm > index 68d9d16..404f6dc 100644 > --- a/src/PVE/HA/Resources.pm > +++ b/src/PVE/HA/Resources.pm > @@ -73,7 +73,8 @@ EODESC > }, > max_restart => { > description => "Maximal number of tries to restart the service on" > - . " a node after its start failed.", > + . " a node after its start failed. When reached, the HA manager will try to" > + . " relocate the service to an eligible node.", > type => 'integer', > optional => 1, > default => 1, Superseded-by: https://lore.proxmox.com/all/20260304083559.75293-1-m.sandoval@proxmox.com/ -- Maximiliano