From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B4E131FF141 for ; Mon, 16 Mar 2026 13:40:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8E82190A6; Mon, 16 Mar 2026 13:40:21 +0100 (CET) From: Maximiliano Sandoval To: Fiona Ebner Subject: superseded: [PATCH qemu-server v2] api: qmclone: print a message with new VMID In-Reply-To: <2ff216bd-1823-472b-b45c-49beefa65d5f@proxmox.com> (Fiona Ebner's message of "Mon, 16 Mar 2026 12:02:56 +0100") References: <20260316101405.174423-1-m.sandoval@proxmox.com> <2ff216bd-1823-472b-b45c-49beefa65d5f@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Mon, 16 Mar 2026 12:39:47 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773664747746 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UQHPBLMA5SFQQSU4W4ORGD5GYZ33P7F2 X-Message-ID-Hash: UQHPBLMA5SFQQSU4W4ORGD5GYZ33P7F2 X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fiona Ebner writes: > Am 16.03.26 um 11:13 AM schrieb Maximiliano Sandoval: >> When doing a linked clone of a template, the task log, journal, nor the >> UPID of the task will log the VMID of the newly created VM. >> >> We add a log message at the start of the clone. This affects both full >> and linked clones. > > Could you send a patch for containers too to keep it consistent? > >> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm >> index 1e226f6f..0587ff97 100644 >> --- a/src/PVE/API2/Qemu.pm >> +++ b/src/PVE/API2/Qemu.pm >> @@ -4487,6 +4487,9 @@ __PACKAGE__->register_method({ >> my $clonefn = sub { >> my ($conffile, $newconf, $oldconf, $vollist, $drives, $fullclone) = >> $load_and_check->(); >> + >> + print("creating a clone of $vmid with ID $newid\n"); > > I think we should put "of VM $vmid" rather than just the ID like we do > in other messages. > >> + >> my $storecfg = PVE::Storage::config(); >> >> # auto generate a new uuid Superseded-by: https://lore.proxmox.com/all/20260316123820.333308-1-m.sandoval@proxmox.com/T/#u -- Maximiliano