From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E8B081FF183 for ; Wed, 17 Dec 2025 14:16:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F7C3227C; Wed, 17 Dec 2025 14:17:33 +0100 (CET) From: Maximiliano Sandoval To: Filip Schauer In-Reply-To: <20251216180904.270167-1-f.schauer@proxmox.com> (Filip Schauer's message of "Tue, 16 Dec 2025 19:08:50 +0100") References: <20251216180904.270167-1-f.schauer@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 17 Dec 2025 14:17:27 +0100 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765977438152 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common/container 0/2] inherit attributes from preexisting directory during mountpoint setup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Filip Schauer writes: > Make mount points inherit the uid, gid, and access mode if the directory > already exists in the container file system. This makes setting up mount > points more convenient when attributes different from uid=0, gid=0, > mode=755 are required. > > As an example, this ensures that directories like /app/data and > /app/cache in the docker.io/weblate/weblate OCI image retain the correct > permissions when adding mount points over them. > > While not explicitly specified by the OCI spec, this matches the > behaviour of implementations such as Docker and Podman. > > Also add the fchmodat syscall, which is required to set the access mode > of a file descriptor that was obtained with open_tree. > > pve-common: > > Filip Schauer (1): > tools: add fchmodat syscall > > src/PVE/Syscall.pm | 1 + > src/PVE/Tools.pm | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > > pve-container: > > Filip Schauer (1): > mountpoint_insert_staged: inherit attributes if directory already > exists > > src/PVE/LXC.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > > Summary over all repositories: > 3 files changed, 19 insertions(+), 0 deletions(-) When used in conjunction with [1] this allows to run the weblate/weblate image without errors. I also tested this with syncthing/syncthing and it looks good. [1] https://lore.proxmox.com/all/20251215174203.267293-1-f.schauer@proxmox.com/ Tested-by: Maximiliano Sandoval -- Maximiliano _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel