From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 03CA81FF138 for ; Wed, 18 Mar 2026 11:25:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E117632410; Wed, 18 Mar 2026 11:26:10 +0100 (CET) From: Maximiliano Sandoval To: Fiona Ebner Subject: Re: [PATCH-SERIES qemu-server/docs 0/2] efi enroll: small improvements to documentation In-Reply-To: <20260318093307.31645-1-f.ebner@proxmox.com> (Fiona Ebner's message of "Wed, 18 Mar 2026 10:32:57 +0100") References: <20260318093307.31645-1-f.ebner@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 18 Mar 2026 11:25:36 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773829495150 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.942 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TCT2PGLWM3GTDA6ASG3LGQUKA33USXCF X-Message-ID-Hash: TCT2PGLWM3GTDA6ASG3LGQUKA33USXCF X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fiona Ebner writes: > qemu-server: > > Fiona Ebner (1): > start vm: check efi vars: clarify when to run the commands for > BitLocker > > src/PVE/QemuServer.pm | 2 ++ > 1 file changed, 2 insertions(+) > > > pve-docs: > > Fiona Ebner (1): > qm: bios/uefi: certificate expiration: mention steps for BitLocker > earlier > > qm.adoc | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > > Summary over all repositories: > 2 files changed, 15 insertions(+), 11 deletions(-) While testing this patch it was not clear to me whether the order of operations mattered after reading the documentation. Given how sensitive this operation might be it is better to err on the side of being precise. Please consider this, Reviewed-by: Maximiliano Sandoval -- Maximiliano