From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DF4611FF142 for ; Fri, 19 Jun 2026 09:20:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2907864A8; Fri, 19 Jun 2026 09:20:35 +0200 (CEST) From: Maximiliano Sandoval To: Christoph Heiss Subject: Re: [PATCH installer] ui: gtk3: set up proper RGBA visual for main window In-Reply-To: <20260618105423.664293-1-c.heiss@proxmox.com> (Christoph Heiss's message of "Thu, 18 Jun 2026 12:54:20 +0200") References: <20260618105423.664293-1-c.heiss@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 19 Jun 2026 09:20:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781853626010 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DR57HFGHLXLJIB3XRP3FG5HUPLHCS6MC X-Message-ID-Hash: DR57HFGHLXLJIB3XRP3FG5HUPLHCS6MC X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Christoph Heiss writes: > This properly fixes all instances of broken damage-tracking with dialogs > and other overlaying widgets on top of the WebKit2 view. > > By using RGBA instead of a the default RGB visual, the GTK <-> X server > interaction for compositing widgets on top of each other seem to work > correctly. > > This was previously worked around in one instance and thus also > effectively reverts commit > > 55c764163 ("gui: redraw window after closing disk setup dialog") > > .. as it is now no longer needed. > > Signed-off-by: Christoph Heiss > --- > proxinstall | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/proxinstall b/proxinstall > index 49b1612..51ead26 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -236,6 +236,13 @@ sub create_main_window { > > Proxmox::UI::init_gtk($gtk_state, $iso_env); > > + # make it play nice without a compositor, i.e. this enables proper damage > + # tracking in GTK in combination with WebKit2 > + my $visual = $window->get_screen()->get_rgba_visual(); > + if ($visual) { > + $window->set_visual($visual); > + } Very interesting find! I booted a new VM using the latest iso where this issue was reproducible and I can confirm that the patch works as expected. The patch fixes a couple of edge cases (even on disk setup dialog) that were not fixed by 55c764163. As a side note, while reviewing gtk source code, it seems that GtkWindow will use RGBA visuals only if gtk_window_supports_client_shadow (which on x11 boils down to whether the compositor supports the _GTK_FRAME_EXTENTS hint) returns true. Looks good to me. Reviewed-by: Maximiliano Sandoval Tested-by: Maximiliano Sandoval -- Maximiliano