From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7DFA01FF0B7 for ; Tue, 25 Aug 2026 16:44:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A08FB20A4A; Tue, 25 Aug 2026 16:44:40 +0200 (CEST) From: Maximiliano Sandoval To: Nicolas Frey Subject: Re: [PATCH manager 0/4] fix #7801: ui: warn about problematic virtio versions on iso select In-Reply-To: <20260825110238.215790-1-n.frey@proxmox.com> (Nicolas Frey's message of "Tue, 25 Aug 2026 13:02:34 +0200") References: <20260825110238.215790-1-n.frey@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 25 Aug 2026 16:44:35 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787669044682 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.895 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) NUMERIC_HTTP_ADDR 0.001 Uses a numeric IP address in URL RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record WEIRD_PORT 0.001 Uses non-standard port number for HTTP Message-ID-Hash: GYBH6MXF2D63HYKZTGAEFLTSMLMMNDNV X-Message-ID-Hash: GYBH6MXF2D63HYKZTGAEFLTSMLMMNDNV X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nicolas Frey writes: > fixes #7801 by scanning for virtio filename regex and warning the user > if the version has known issues attributed to it [0]. > > I tried the following approaches to warn the user: > - via a (quite intrusive) pop-up > - a warning box after the iso selector > - an inline hoverable icon on the selector field > > I felt the second approach resulted in the best UX, so I went with > that in this series. If we have any better/more standard way to warn > about things like these which I missed, please LMK! > > [0] https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers > > [..] I built these patches on top of the current head 14a22df35. Some things I noticed: - The `pmx-hint` class is generally used for such warnings. The current approach of an icon works for me, but it does not match how it is done in multiple other warnings. - The message "'Upgrading to version 0.1.266 or newer is recommended." might lead a user to try with the current latest version (0.1.285) which will then warn them to downgrade. Perhaps mention that 0.1.215 up to 0.1.262 (including/not including) can have read errors and performance issues and let the user make a decision based on that. - Same with the downgrade message one sees when trying 0.1.285. These messages should remain accurate and relevant after we get new releases of the VirtIO drivers (which might or not have more issues). - The Hardware panel does not load. I see the following error in the console: Uncaught TypeError: can't access property "getById", me.store is undefined getObjectValue https://10.10.10.148:8006/proxmoxlib.js?ver=v5.2.8-t1786709937:7420 handler https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57264 editorFactory https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57221 initComponent https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57263 ExtJS 8 activateCard https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:15543 selectionchange https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:15487 ExtJS 16 proxmoxlib.js:7420:19 getObjectValue https://10.10.10.148:8006/proxmoxlib.js?ver=v5.2.8-t1786709937:7420 handler https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57264 editorFactory https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57221 initComponent https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:57263 ExtJS 8 activateCard https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:15543 selectionchange https://10.10.10.148:8006/pve2/js/pvemanagerlib.js?ver=9.2.11:15487 ExtJS 16 when going to the Hardware Panel of a VM. I am not 100% sure this is caused by the changes here, but the error is gone after downgrading to the version in staging. One thing I was not able to test was whether these warnings were also visible for VMs having a ostype different than windows. -- Maximiliano