From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 3AA081FF0C0
	for <inbox@lore.proxmox.com>; Wed, 21 Oct 2026 16:04:07 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id DA6B5215D4;
	Wed, 21 Oct 2026 16:04:04 +0200 (CEST)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Subject: Re: [PATCH access-control/docs v2 0/2] Update default password hash
 function to yescrypt
In-Reply-To: <20261021113808.233146-1-s.sterz@proxmox.com> (Shannon Sterz's
	message of "Wed, 21 Oct 2026 13:38:06 +0200")
References: <20261021113808.233146-1-s.sterz@proxmox.com>
User-Agent: mu4e 1.12.9; emacs 30.1
Date: Wed, 21 Oct 2026 16:04:00 +0200
Message-ID: <s8oecdjtajz.fsf@toolbox>
MIME-Version: 1.0
Content-Type: text/plain
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792591440902
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.760 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: UEBLSU4EHXNRX72NKBD2IW5RI6AY6AFT
X-Message-ID-Hash: UEBLSU4EHXNRX72NKBD2IW5RI6AY6AFT
X-MailFrom: m.sandoval@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Shannon Sterz <s.sterz@proxmox.com> writes:

> Also updates the password hash when a user logs in.
>
> Changelog
> ---------
>
> * v1: https://lore.proxmox.com/pve-devel/20261009122729.178682-2-s.sterz@proxmox.com/
>
> - changes since v1:
>     + added a patch that actually opts in the pve and pam realm to yescrypt
>       hashes and updates hashes on login
>
> access-control:
>
> [...]
>
> docs:
>
> [...]

Modulo some very small comments regarding documentation (see reply to
commit), the series looks good to me.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano