From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id F24FB1FF173
for <inbox@lore.proxmox.com>; Mon, 24 Feb 2025 09:48:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C892B2CD06;
Mon, 24 Feb 2025 09:48:48 +0100 (CET)
References: <20250219111740.200819-1-m.sandoval@proxmox.com>
<20250219111740.200819-4-m.sandoval@proxmox.com>
<a4154a19-4432-4ec8-b890-101175376b6c@proxmox.com>
User-agent: mu4e 1.10.8; emacs 29.4
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Date: Mon, 24 Feb 2025 09:43:19 +0100
In-reply-to: <a4154a19-4432-4ec8-b890-101175376b6c@proxmox.com>
Message-ID: <s8ocyf7n2y9.fsf@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.149 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence
Subject: Re: [pve-devel] [PATCH storage v4 4/7] btrfs: forcefully set image
to readwrite
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Fiona Ebner <f.ebner@proxmox.com> writes:
> I want to apply the series with a small follow-up, i.e.
>
>> btrfs: avoid superfluous check in foreach_snapshot_of_subvol() helper
>>
>> The helper iterates with the BTRFS_SNAPSHOT_REGEX regular expression,
>> so there will always be a snapshot name.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/Storage/BTRFSPlugin.pm | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
>> index a28996c..e47f25e 100644
>> --- a/src/PVE/Storage/BTRFSPlugin.pm
>> +++ b/src/PVE/Storage/BTRFSPlugin.pm
>> @@ -417,7 +417,6 @@ my sub foreach_snapshot_of_subvol : prototype($$) {
>> my ($volume, $name, $snap_name) = ($1, $2, $3);
>> return if !path_is_subvolume("$dir/$volume");
>> return if $name ne $basename;
>> - return if !defined $snap_name;
>> $code->($snap_name);
>> });
>> }
>
> but I need to ask about this patch first.
Requiring the argument to be defined sounds sensible for a helper imo.
> Am 19.02.25 um 12:17 schrieb Maximiliano Sandoval:
>> When a subvolume is transferred via btrfs send/receive the resulting
>> image contains the received_uuid property set. This property is required
>> to do incremental snapshots.
>>
>> A downside though is that once the received_uuid property is set, it is
>> not possible to make the image readwrite again without the force (-f)
>> flag, and in such case the received_uuid property is lost. Since we know
>> the images are only set to rw for the duration of the move, it is safe
>> to set the flag forcefully and then in a future commit add the
>> received_uuid property by force.
>
> What do you mean exactly with "add the received_uuid property by force"?
> What would the command for that be? Just want to make sure we don't
> block our way to support incremental export/import later (it's broken
> right now [0], but we might want to implement it at some point).
>
> [0]:
> https://lore.proxmox.com/pve-devel/20250221154111.73194-1-f.ebner@proxmox.com/T/
>
There is the BTRFS_IOC_SET_RECEIVED_SUBVOL ioctl. See [1].
[1] https://btrfs.readthedocs.io/en/latest/btrfs-ioctl.html#overview
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>> src/PVE/Storage/BTRFSPlugin.pm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
>> index 7dec6e8..9fc51ef 100644
>> --- a/src/PVE/Storage/BTRFSPlugin.pm
>> +++ b/src/PVE/Storage/BTRFSPlugin.pm
>> @@ -895,7 +895,7 @@ sub volume_import {
>> # Rotate the disk into place, first the current state:
>> # Note that read-only subvolumes cannot be moved into different directories, but for the
>> # "current" state we also want a writable copy, so start with that:
>> - $class->btrfs_cmd(['property', 'set', "$tmppath/$diskname\@$snapshot", 'ro', 'false']);
>> + $class->btrfs_cmd(['property', 'set', '-f', "$tmppath/$diskname\@$snapshot", 'ro', 'false']);
>> PVE::Tools::renameat2(
>> -1,
>> "$tmppath/$diskname\@$snapshot",
>> @@ -917,7 +917,7 @@ sub volume_import {
>>
>> # Now go through the remaining snapshots (if any)
>> foreach my $snap (@snapshots) {
>> - $class->btrfs_cmd(['property', 'set', "$tmppath/$diskname\@$snap", 'ro', 'false']);
>> + $class->btrfs_cmd(['property', 'set', '-f', "$tmppath/$diskname\@$snap", 'ro', 'false']);
>> PVE::Tools::renameat2(
>> -1,
>> "$tmppath/$diskname\@$snap",
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel