From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 730341FF13A for ; Wed, 24 Jun 2026 10:44:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EB98124FB; Wed, 24 Jun 2026 10:44:16 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: Re: [PATCH qemu-server 2/2] vm start: log qemu version when starting a VM In-Reply-To: <20260624084201.168436-2-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Wed, 24 Jun 2026 10:40:45 +0200") References: <20260624084201.168436-1-m.sandoval@proxmox.com> <20260624084201.168436-2-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 24 Jun 2026 10:44:12 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782290640101 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GUK7HBGQYIE46VLD5GSH5UH6ULYHBRNI X-Message-ID-Hash: GUK7HBGQYIE46VLD5GSH5UH6ULYHBRNI X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > Previously, having the system journal and task logs from a boot was not > enough to determine which qemu version is installed nor the running QEMU > version of a VM. This is addressed by logging pve-qemu-kvm's package > version when starting the VM. > > The package version is obtained with the 'query-version' qmp command. > > Signed-off-by: Maximiliano Sandoval Reading the ->{package} directly from 'query-version', instead of using get_running_qemu_version, was: Suggested-by: Fiona Ebner -- Maximiliano