From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 425A31FF13B for ; Wed, 25 Feb 2026 17:02:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6162EB634; Wed, 25 Feb 2026 17:03:35 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: Re: [PATCH manager 0/7] ui: qga: add checkbox for guest-fsfreeze In-Reply-To: <20260225154614.681858-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Wed, 25 Feb 2026 16:45:39 +0100") References: <20260225154614.681858-1-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 25 Feb 2026 17:03:00 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772035363591 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.974 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.113 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.358 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.659 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FYGSNMWPRSS4GO56SZ6ITRCDAO5RNH7C X-Message-ID-Hash: FYGSNMWPRSS4GO56SZ6ITRCDAO5RNH7C X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > This was discussed off-list with Fiona. > > Something that was missing from Fiona's comments was giving the "hint" css class > to the "Deprecated" part of the old checkbox's label. I was not sure how to make > that work in extjs. > > The migration would work as follows: > > - The new key takes preference over the old one so using the old one is OK. > - If the key is in the config file then the old checkbox would dbe displayed > - But delete the key from the config if the freeze is enabled, since it is the default I forgot to mention here that the old key was moved to the advanced options to prevent having two very similar rows together as it was deemed to confusing. -- Maximiliano