From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2AE661FF0B3 for ; Wed, 11 Nov 2026 10:42:43 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F320621663; Wed, 11 Nov 2026 10:42:39 +0100 (CET) From: Maximiliano Sandoval To: Kefu Chai Subject: Re: [PATCH ceph squid-stable-9 v2] patches: link the PVE cephx migration docs in the insecure key warnings In-Reply-To: <20261016103138.3896717-1-k.chai@proxmox.com> (Kefu Chai's message of "Fri, 16 Oct 2026 18:31:38 +0800") References: <20261016103138.3896717-1-k.chai@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 11 Nov 2026 10:42:36 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794390156212 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.727 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SLRIHQTVCGESA5AQZANX7HQ6VSKOV2YB X-Message-ID-Hash: SLRIHQTVCGESA5AQZANX7HQ6VSKOV2YB X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Kefu Chai writes: > Ceph 19.2.6 and 20.2.4 added health checks for keys, service tickets and > cipher settings that still use aes. A node picking up the point release > starts reporting them, and the summary that `ceph -s` prints says only > that something is insecure, not what to do about it. The migration on > PVE goes through pve-cephx-rotate-service-keys, which also updates the > key copies that PVE manages, so the upstream procedure is not what a > user should follow here. > > The web interface already explains every one of these checks and puts > the guide next to it, but a user reading `ceph -s` or `ceph health` over > ssh gets the summary and nothing else, so the link has to be in the > summary too. > > Append it to AUTH_INSECURE_KEYS_ALLOWED and to nothing else. That check > is raised for as long as the monitors still allow aes, and the allowed > ciphers are restricted in the last of the three documented steps and > only by the helper, so the link tracks whether the migration is > finished. The other checks clear earlier: the two with error severity go > away in step 1, the rotating service key warning expires by itself, and > the last two are the ones the PVE docs tell users to mute while an > incompatible client keeps the migration from finishing. Appending the > url to those as well would print it up to six times in a single > `ceph health` line and in the cluster log. > > The link is only useful on PVE, so there is no upstream commit behind > this patch: it is ours, and it stays in the series. > > Signed-off-by: Kefu Chai This patch needs a rebase. -- Maximiliano