From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B18941FF150 for ; Mon, 06 Jul 2026 10:16:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1EC6E21429; Mon, 06 Jul 2026 10:16:00 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: superseded: [PATCH backup v3 0/3] fix #7054: client: remove trailing newlines from credentials In-Reply-To: <20260223093710.36009-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Mon, 23 Feb 2026 10:37:04 +0100") References: <20260223093710.36009-1-m.sandoval@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Mon, 06 Jul 2026 10:15:54 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783325744090 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FAHQ2BTEHGI2Q4OU4OLPOXW3J2CJM2ZY X-Message-ID-Hash: FAHQ2BTEHGI2Q4OU4OLPOXW3J2CJM2ZY X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > See the first commit for more details. > > This was tested with proxmox-backup-client making a login/backup using different > credentials with and without newlines. The commands were similar to the > systemd-run commands at the Backup Client Usage docs. > > I did not find a way to create the keyfile with newlines in its password using > proxmox-backup-client since it reads from the tty stdin, but surely it could be > created manually. Perhaps it is safe-ish to also remove trailing control > characters from the encryption password but this seems a safer approach for now. Superseded-by: https://lore.proxmox.com/all/20260706080246.108256-1-m.sandoval@proxmox.com/T/#u -- Maximiliano