From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EC67B1FF0A7 for ; Wed, 16 Sep 2026 11:32:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5EA8121497; Wed, 16 Sep 2026 11:32:08 +0200 (CEST) From: Maximiliano Sandoval To: Jonas Theisen Subject: Re: [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change In-Reply-To: <20260915091758.85522-1-j.theisen@proxmox.com> (Jonas Theisen's message of "Tue, 15 Sep 2026 11:16:56 +0200") References: <20260915091758.85522-1-j.theisen@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 16 Sep 2026 11:32:03 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789551124082 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.827 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OILAV5OO34S4U7Z5KBBISPFIH2TWRJZH X-Message-ID-Hash: OILAV5OO34S4U7Z5KBBISPFIH2TWRJZH X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Jonas Theisen writes: > To allow reuse of the same code this patch series factors out > the relevant function inside the APT part of the API and reuses > the function on change of the http_proxy variable in the Cluster API. > > This is to ensure a consistent state after a change of the HTTP proxy > without having to run a Refresh / apt update through the PVE tooling. > > https://bugzilla.proxmox.com/show_bug.cgi?id=8031 Looks good to me. Reviewed-by: Maximiliano Sandoval -- Maximiliano