Re: [PATCH guest-common 0/2] fix #1964: replication config: add a setting to skip freezing guest filesystems

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

"Shannon Sterz" <s.sterz@proxmox.com> writes:

> On Mon Jul 6, 2026 at 4:03 PM CEST, Maximiliano Sandoval wrote:
>> See the second commit message for more information.
>>
>> We sneak a change removing an unused Data::Dumper import.
>>
>> Tested:
>>
>> - Created a VM with ID 101 in a cluster with nodes pve1 and pve2
>> - Enabled the QGA service inside the guest
>> - Created a replication job with
>>
>> pve2 $ pvesr create-local-job 101-1 pve1 --skip-freeze-fs 1 --schedule '*/1'
>>
>> - Start the VM
>> - Ran: pvesr schedule-now 101-1
>> - cat /var/log/pve/replicate/101-1
>> - checked that it contains the added line in the logs.
>>
>> Then repeated the whole thing without specifying --skip-freeze-fs to ensure
>> nothing was broken.
>>
>> Maximiliano Sandoval (2):
>>   replication config: remove unused Data::Dumper
>>   fix #1964: replication config: add a setting to skip freezing guest
>>     filesystems
>>
>>  src/PVE/Replication.pm       | 7 +++++++
>>  src/PVE/ReplicationConfig.pm | 9 ++++++++-
>>  2 files changed, 15 insertions(+), 1 deletion(-)
>
> seems to work as advertised and the code changes seem to fairly straight
> forward to me. so consider this:
>
> Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
> Tested-by: Shannon Sterz <s.sterz@proxmox.com>
>
> one small thing i noticed is that if a node does not have the updated
> package, editing the replication job through that node's ui will
> silently drop the new option. however, that is unrelated to this series
> and a more general issue. editing the job on a node with these changes
> keeps the option in place as expected.

Thanks for the feedback. I noticed this morning that "wether" is a typo,
from the Cambridge Dictionary:

wether n.
a male sheep that has been castrated

I suppose that s/wether/whether/ can be done while applying.

This has been requested in the following support cases: #9211193,
#0063246, #5761134, #3261710.

-- 
Maximiliano