From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DE4041FF140 for ; Fri, 08 May 2026 09:49:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C28BF7DC; Fri, 8 May 2026 09:49:00 +0200 (CEST) Date: Fri, 8 May 2026 09:48:50 +0200 From: Arthur Bied-Charreton To: Fiona Ebner Subject: Re: [PATCH qemu-server v4 07/17] cpu config: set 'type' field before writing Message-ID: References: <20260430160109.565536-1-a.bied-charreton@proxmox.com> <20260430160109.565536-8-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778226423437 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.782 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cpuconfig.pm] Message-ID-Hash: HFRE26WF3Z3RBH24MNWVVADQWG6PRBHJ X-Message-ID-Hash: HFRE26WF3Z3RBH24MNWVVADQWG6PRBHJ X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, May 07, 2026 at 02:24:22PM +0200, Fiona Ebner wrote: > Am 30.04.26 um 6:00 PM schrieb Arthur Bied-Charreton: > > Fix write_config by adding 'type' to every section, otherwise SectionConfig > > fails, because it requires each entry in $cfg->{ids} to have a 'type' > > key. > > > > Signed-off-by: Arthur Bied-Charreton > > --- > > src/PVE/QemuServer/CPUConfig.pm | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm > > index 78603acc..b606aaa5 100644 > > --- a/src/PVE/QemuServer/CPUConfig.pm > > +++ b/src/PVE/QemuServer/CPUConfig.pm > > @@ -537,6 +537,7 @@ sub write_config { > > > > # saved in section header > > delete $model_conf->{cputype}; > > + $model_conf->{type} = $class->type(); > > Maybe we should rather call check_config() in the API endpoints like > other section config users do? Or would that not work nicely here? > It works well, will switch to that. I was not aware of this helper, thanks for the tip! > > } > > > > $class->SUPER::write_config($filename, $cfg); >