From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6A71C1FF137 for ; Tue, 31 Mar 2026 11:16:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3DC5915475; Tue, 31 Mar 2026 11:16:34 +0200 (CEST) Date: Tue, 31 Mar 2026 11:15:59 +0200 From: Gabriel Goller To: Daniel Kral Subject: Re: [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency Message-ID: Mail-Followup-To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260331090050.128253-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260331090050.128253-1-d.kral@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774948504132 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.474 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VT5G2KVOMGJR3SI3YA3D5ATXAGG6K2ZB X-Message-ID-Hash: VT5G2KVOMGJR3SI3YA3D5ATXAGG6K2ZB X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 31.03.2026 11:00, Daniel Kral wrote: > proxmox-frr requires the jinja template files provided by > proxmox-frr-templates at compile time to build the crate. > > Signed-off-by: Daniel Kral > --- > I've stumbled on this when the build for libpve-rs-perl failed because I > didn't have the package installed. > > proxmox-frr/debian/control | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control > index 265fa70..e918000 100644 > --- a/proxmox-frr/debian/control > +++ b/proxmox-frr/debian/control > @@ -18,7 +18,8 @@ Build-Depends-Arch: cargo:native , > librust-serde-1+derive-dev , > librust-serde-repr-0.1+default-dev , > librust-thiserror-2+default-dev , > - librust-tracing-0.1+default-dev > + librust-tracing-0.1+default-dev , > + proxmox-frr-templates > Maintainer: Proxmox Support Team > Standards-Version: 4.7.2 > Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git > @@ -43,7 +44,8 @@ Depends: > librust-serde-1+derive-dev, > librust-serde-repr-0.1+default-dev, > librust-thiserror-2+default-dev, > - librust-tracing-0.1+default-dev > + librust-tracing-0.1+default-dev, > + proxmox-frr-templates > Provides: > librust-proxmox-frr+default-dev (= ${binary:Version}), > librust-proxmox-frr-0-dev (= ${binary:Version}), > -- > 2.47.3 Arghh, I had this at some point but it slipped out. Sorry about that! LGTM, Consider: Reviewed-by: Gabriel Goller