From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4FBE61FF164 for ; Fri, 4 Jul 2025 08:46:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F0E2305BE; Fri, 4 Jul 2025 08:45:56 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Fri, 4 Jul 2025 08:45:07 +0200 In-Reply-To: <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com> References: <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot Content-Type: multipart/mixed; boundary="===============6447390302690831186==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============6447390302690831186== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB901D547D for ; Fri, 4 Jul 2025 08:45:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 992453019F for ; Fri, 4 Jul 2025 08:45:22 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Jul 2025 08:45:18 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 23C0A862E57; Fri, 4 Jul 2025 08:45:09 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 2172A1159334; Fri, 4 Jul 2025 08:45:09 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot Date: Fri, 4 Jul 2025 08:45:07 +0200 Message-Id: <20250704064507.511884-14-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com> References: <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.105 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Returns if the volume is supporting qemu snapshot: 'internal' : do the snapshot with qemu internal snapshot 'external' : do the snapshot with qemu external snapshot undef : does not support qemu snapshot Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 19 +++++++++++++++++++ src/PVE/Storage/DirPlugin.pm | 10 ++++++++++ src/PVE/Storage/LVMPlugin.pm | 7 +++++++ src/PVE/Storage/Plugin.pm | 13 +++++++++++++ src/PVE/Storage/RBDPlugin.pm | 6 ++++++ 5 files changed, 55 insertions(+) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index d83770c..e794f7b 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -2350,6 +2350,25 @@ sub rename_volume { ); } +# Returns the method type to take a snapshot with qemu: +# 'internal' : support snapshot with qemu internal snapshot +# 'external' : support do the snapshot with qemu external snapshot +# undef : don't support qemu snapshot +sub volume_support_qemu_snapshot { + my ($cfg, $volid) = @_; + + my ($storeid, $volname) = parse_volume_id($volid, 1); + + if ($storeid) { + my $scfg = storage_config($cfg, $storeid); + + my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); + + return $plugin->volume_support_qemu_snapshot($storeid, $scfg, $volname); + } + return undef; +} + # Various io-heavy operations require io/bandwidth limits which can be # configured on multiple levels: The global defaults in datacenter.cfg, and # per-storage overrides. When we want to do a restore from storage A to storage diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm index ae5d083..0f8776b 100644 --- a/src/PVE/Storage/DirPlugin.pm +++ b/src/PVE/Storage/DirPlugin.pm @@ -315,4 +315,14 @@ sub get_import_metadata { }; } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return if $format ne 'qcow2'; + + my $type = $scfg->{snapext} ? 'external' : 'internal'; + return $type; +} + 1; diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index ef010b8..3e3e48c 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -1199,4 +1199,11 @@ sub get_snap_volname { return $class->get_snap_name($volname, $snapname); } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return 'external' if $format eq 'qcow2'; +} + 1; diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 68d17ff..bf190d2 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2292,6 +2292,19 @@ sub qemu_blockdev_options { return $blockdev; } + +# Returns the method type to take a snapshot with qemu: +# 'internal' : support snapshot with qemu internal snapshot +# 'external' : support do the snapshot with qemu external snapshot +# undef : don't support qemu snapshot + +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return 'internal' if $format eq 'qcow2'; +} + # Used by storage plugins for external backup providers. See PVE::BackupProvider::Plugin for the API # the provider needs to implement. # diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index 883b0e4..8065cfc 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -1057,4 +1057,10 @@ sub rename_volume { return "${storeid}:${base_name}${target_volname}"; } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + return 'internal' if !$scfg->{krbd}; +} + 1; -- 2.39.5 --===============6447390302690831186== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============6447390302690831186==--