From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 2AE4B1FF15E
for <inbox@lore.proxmox.com>; Tue, 11 Mar 2025 06:53:59 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 328B9717B;
Tue, 11 Mar 2025 06:53:50 +0100 (CET)
References: <20250228140136.124286-1-s.hanreich@proxmox.com>
<20250228140136.124286-2-s.hanreich@proxmox.com>
<D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com>
In-Reply-To: <D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com>
Date: Tue, 11 Mar 2025 09:53:22 +0400
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.927.1741672428.293.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Matthieu Pignolet via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Matthieu Pignolet <m@mpgn.dev>,
pve-devel <pve-devel-bounces@lists.proxmox.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum
value for ASN
Content-Type: multipart/mixed; boundary="===============9068358492274726288=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.
--===============9068358492274726288==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <m@mpgn.dev>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 8EAF7D56CD
for <pve-devel@lists.proxmox.com>; Tue, 11 Mar 2025 06:53:47 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 769CE718E
for <pve-devel@lists.proxmox.com>; Tue, 11 Mar 2025 06:53:47 +0100 (CET)
Received: from tbjjbihbhdeb.turbo-smtp.net (tbjjbihbhdeb.turbo-smtp.net [199.187.173.41])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 11 Mar 2025 06:53:44 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mpgn.dev;
s=turbo-smtp; x=1742277225; h=Received:Received:Received:
MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
To:Cc:Content-Type:Feedback-Id; bh=HF7p9k4NWm+8tCOOEKKuP9YG9STKY
kI6hqYvXSdiiJo=; b=PK66Nt1/AsiatID8yLrIvstdme3hDFCoAeYxmTWcEgnPa
tBXQ5c51EQ53bPMQhX8V1F7TNtCEZJE3JJVL5HnaDNd1no0FgHvpaCZr4sGnWbCf
rtxsNzcMJZlzRBRDvgmjCd7AQotfTfIi4VDCcoY2jyhp0BbV4c7x0Kej+gvVwY=
Received: (qmail 3745371 invoked from network); 11 Mar 2025 05:53:37 -0000
Received: from ?UNAVAILABLE? by turbo-smtp.com with SMTP; 11 Mar 2025 05:53:36 -0000
Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2fee05829edso9960131a91.3; Mon, 10 Mar 2025 22:53:36 -0700 (PDT)
X-TurboSMTP-Tracking: 64-0162ab32-00001be72563c2c16000-000-49b1698e
X-Gm-Message-State: AOJu0YyeOwr1WkqkWiscx/PoFLYQr02GTkuMwv4a22T1efVJX5KuixkO O0sUMFDpoRm7aiu2+n0CZRvqsdn2y5AjQ9dZbJwAslqmxWgvAZpPcL77qO2E5fHZ1CmDszyf6y/ K7ihhxQPI4SwnwwM9VLkcNyLMNA0=
X-Google-Smtp-Source: AGHT+IHLzpzhTzIz8k8qJ8Tk8NioOl2sjMjCKryRVjZeQN9nFVz+XCO+VXunMFJ0Do+MSRAFYjWgY/KLEbMp8q1wQVQ=
X-Received: by 2002:a17:90b:4ad0:b0:2ff:5cb7:5e73 with SMTP id 98e67ed59e1d1-2ff7cef8994mr20643898a91.23.1741672414708; Mon, 10 Mar 2025 22:53:34 -0700 (PDT)
MIME-Version: 1.0
References: <20250228140136.124286-1-s.hanreich@proxmox.com> <20250228140136.124286-2-s.hanreich@proxmox.com> <D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com>
In-Reply-To: <D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com>
From: Matthieu Pignolet <m@mpgn.dev>
Date: Tue, 11 Mar 2025 09:53:22 +0400
X-Gmail-Original-Message-Id: <CAB+WsT0gqCbcZCvhVSewYF-15dM05YGEx=-bhT2W1Njd_poO_g@mail.gmail.com>
X-Gm-Features: AQ5f1JpdvBezSsCM4_RGDjSEYRr37cAuit6-bqLZLM6UGj_6TgWTFb_ks6RSEkY
Message-ID: <CAB+WsT0gqCbcZCvhVSewYF-15dM05YGEx=-bhT2W1Njd_poO_g@mail.gmail.com>
Subject: Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>
Feedback-Id: 23243570
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.002 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
HTML_MESSAGE 0.001 HTML included in message
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,evpnplugin.pm,mpgn.dev]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
According to my testing, when using the `autort` for RT auto-derivation
(from the frr patch) causes issues because it doesn't work with 32 bits
ASNs, effectively calling the fallback to restarting frr to apply the
config (which ignores the autort instruction).
Le lun. 10 mars 2025, 19:30, Shannon Sterz <s.sterz@proxmox.com> a =C3=A9cr=
it :
> On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote:
> > ASNs are 32-bit unsigned integers where the maximum value is
> > 4294967295.
> >
> > Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> > ---
> > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > index c245ea2..78c9798 100644
> > --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > @@ -24,7 +24,7 @@ sub properties {
> > type =3D> 'integer',
> > description =3D> "autonomous system number",
> > minimum =3D> 0,
> > - maximum =3D> 4294967296
> > + maximum =3D> 4294967295
>
> just a small nit, it might be nicer to express that as `2**32-1` if
> that's an option.
>
> > },
> > peers =3D> {
> > description =3D> "peers address list.",
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
--===============9068358492274726288==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============9068358492274726288==--